[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[IDV #SQR-320006]: Can't reset smoothing



> Yuan-
> 
> What happens if someone smooths the grid and then changes the skip
> factor?  Does the smoothing get applied to the decimated grid?
> 
> Don

No, it is easy to add the checking of skip factor. But I didn't see any place 
you can change the skip factor after the contour created.

Yuan
> 
> On 1/11/11 3:13 PM, Unidata IDV Support wrote:
> >> Yuan-
> >>
> >> This doesn't work when you change the smoothing factor for a particular
> >> smoothing type like Gaussian.  The first time you select that, the
> >> smoothing is correct.  However, when you change the factor, the old
> >> smoothing is the same as the new smoothing, so it puts in the unsmoothed
> >> grid.  Load in the same parameter twice as contours.  On one the the
> >> controls, change the smoothing type, and then play around with the
> >> smoothing factor and you'll see what I mean.  If you still want to get a
> >> new release out this week, you might just back out of the change and
> >> leave it as a known bug for the next release rather than introduce new 
> >> bugs.
> >>
> >> Don
> >
> > I re did the logic of checking, adding the smooth factor, now it is working 
> > better. I even tested to apply the
> > same smoothing method, and all worked as expect.
> >
> > Let me know if I miss anything.
> >
> >
> > Yuan
> >>
> >> On 1/10/11 2:16 PM, Unidata IDV Support wrote:
> >>>> One for the TODO list:
> >>>>
> >>>> In the PlanViewControls, when you smooth the grid, you can't go back to
> >>>> an unsmoothed grid without reloading the data.  There is code in
> >>>> getSliceForDisplay that checks to see if the smoothing is not NONE
> >>>> before it does the smoothing.  This was done for performance reasons
> >>>> because every time you did something that would call this method (e.g.
> >>>> skip factor), you'd also go through the smoothing code which can be
> >>>> expensive.  A possible solution would be to have an oldSmoothingType and
> >>>> check if it's changed.  Another would be that if smoothing equals
> >>>> LABEL_NONE, then use retfield (another if block inside the checkFlag 
> >>>> block).
> >>>>
> >>>> The implementation is left as a simple exercise for the reader.
> >>>>
> >>>> Don
> >>>
> >>> I have the code changed to allow user moving back to non smoothing to the 
> >>> field.
> >>>
> >>>
> >>> Yuan
> >>>> --
> >>>> Don Murray
> >>>> NOAA/ESRL/PSD and CIRES
> >>>> 303-497-3596
> >>>> http://www.esrl.noaa.gov/psd/people/don.murray/
> >>>>
> >>>>
> >>>
> >>>
> >>> Ticket Details
> >>> ===================
> >>> Ticket ID: SQR-320006
> >>> Department: Support IDV
> >>> Priority: Normal
> >>> Status: Closed
> >>>
> >>
> >> --
> >> Don Murray
> >> NOAA/ESRL/PSD and CIRES
> >> 303-497-3596
> >> http://www.esrl.noaa.gov/psd/people/don.murray/
> >>
> >>
> >
> >
> > Ticket Details
> > ===================
> > Ticket ID: SQR-320006
> > Department: Support IDV
> > Priority: Normal
> > Status: Closed
> >
> 
> --
> Don Murray
> NOAA/ESRL/PSD and CIRES
> 303-497-3596
> http://www.esrl.noaa.gov/psd/people/don.murray/
> 
> 


Ticket Details
===================
Ticket ID: SQR-320006
Department: Support IDV
Priority: Normal
Status: Open