Hi Ethan, i attach a patch, i hope it works as planned. it was made from the root of my git repo agains the modified code (ncWMS-master) and the unmodified (ncWMS) repo. it modifies 3 files. it's a shame not to be able to use github, if someone ever manages to do a fork/pull request from windows (i'm using the 'github for windows' client btw) without all files being marked as modified i'd be interested to hear how it was done. -i -----Message d'origine----- De : thredds-bounces@xxxxxxxxxxxxxxxx [mailto:thredds-bounces@xxxxxxxxxxxxxxxx] De la part de Ethan Davis Envoyé : Friday, 29 March 2013 20:45 À : thredds@xxxxxxxxxxxxxxxx Objet : Re: [thredds] ncwms customisation from TDS source.. Hi Ivan, Lets try a patch file (if its not too much trouble). We have Windows, Linux, and OSX developers here and have never run into EOL problems. (Although I do occasionally see a message from IntelliJ about EOL differences, they never show up in git.) I don't set and I'm not aware of anyone here setting any git attibutes. Thanks, Ethan On 3/29/2013 12:31 PM, Ivan Price wrote: > Hi there, > > i did a pull request in github, i'm not sure if you can use it from > there. > > the fork is here: https://github.com/ivanprice/ncWMS > > I only modified 3 files but sadly it is marking everything as > modified, I think because it has converted all the EOL to windows > format (i am on windows). > > if a patch would be easier then i can send a patch, i'm surprised the > EOLs are not handled better, but it's probably my misuse causing the > problem. btw i followed the instructions regarding the recommended > .gitattributes file: # Auto detect text files and perform LF > normalization * text=auto > > have a good weekend, > > -ivan > > > > > -----Message d'origine----- > De : thredds-bounces@xxxxxxxxxxxxxxxx > [mailto:thredds-bounces@xxxxxxxxxxxxxxxx] De la part de Ethan Davis > Envoyé : Thursday, 28 March 2013 00:13 À : thredds@xxxxxxxxxxxxxxxx > Objet : Re: [thredds] ncwms customisation from TDS source.. > > Hi Ivan, > > Yes, we would be happy to fold your changes into the TDS. If you want to go > the git route, feel free to make a pull request on gitHub or point us to a > publicly available git repo. Another option is to send us a patch file. > Whatever works for you. > > We'll touch base with the ncWMS folks as well to see about folding this into > the main ncWMS code base. > > Thanks, > > Ethan > > On 3/27/2013 4:48 AM, Ivan Price wrote: >> Thanks Ethan and Kyle for your assistance on this. >> >> thanks to the fact that the build processes for both TDS and its >> NCWMS were so well packaged and prepared, we have had success in >> making our (quite minor) changes. The result is vector maps like the >> one attached. >> >> we make use of the pre-existing vectorScale WMS parameter, and added >> a new one: vectorStep. the vectorScale affects the size of the >> symbols, the vectorStep affects the distance between them. We wanted >> the ability to control these separately. The ideal would be for all >> this to be used optionally, in our case it is 'always on'. >> >> also, we could not get antialiasing working correctly, there is >> definite room for improvement there. >> >> we'd be happy to share the changes we made in the interest of having >> them included in the main TDS, if this is interesting please let me >> know the best way to do so (btw i'm a git newbie). >> >> thanks again and regards >> >> -i >> >> >> >> -----Message d'origine----- >> De : thredds-bounces@xxxxxxxxxxxxxxxx >> [mailto:thredds-bounces@xxxxxxxxxxxxxxxx] De la part de Ethan Davis >> Envoyé : Tuesday, 26 March 2013 16:36 À : thredds@xxxxxxxxxxxxxxxx >> Objet : Re: [thredds] ncwms customisation from TDS source.. >> >> Hi Ivan, >> >> The Ant buildTds.xml file is deprecated in favor of the Maven pom.xml file. >> We no longer maintain the Ant TDS build script. >> >> Cheers, >> >> Ethan >> >> On 3/26/2013 7:32 AM, Kyle Wilcox wrote: >>> You can find the ncWMS code that THREDDS is using here: >>> https://github.com/Unidata/ncWMS >>> >>> >>> >>> Specifically, vectors are created here: >>> https://github.com/Unidata/ncWMS/blob/master/src/java/uk/ac/rdg/resc >>> / >>> n >>> cwms/graphics/ImageProducer.java#L185 >>> >>> >>> >>> And the classes that actually do the drawing: >>> >>> https://github.com/Unidata/ncWMS/blob/master/src/java/uk/ac/rdg/resc >>> / >>> n >>> cwms/graphics/VectorFactory.java >>> >>> https://github.com/Unidata/ncWMS/blob/master/src/java/uk/ac/rdg/resc >>> / >>> n >>> cwms/graphics/BarbFactory.java >>> >>> >>> >>> In your case, you would need to apply an scale transform on the >>> drawn object based on magnitude. >>> >>> >>> >>> >>> >>> For building NcWMS for TDS, there is an ANT script here: >>> https://github.com/Unidata/ncWMS/blob/master/buildTds.xml with a >>> target of "buildNcwmsJar". >>> >>> >>> >>> >>> >>> >>> >>> *From:*Ivan Price [mailto:Ivan.Price@xxxxxxxxxxx] >>> *Sent:* Tuesday, March 26, 2013 9:10 AM >>> *To:* Kyle Wilcox; thredds@xxxxxxxxxxxxxxxx >>> *Subject:* RE: ncwms customisation from TDS source.. >>> >>> >>> >>> Hi Kyle, thanks for getting back to me.. >>> >>> >>> >>> I'm sorry i think i wasn't clear.. i'm aware there are 'new' vector >>> styles in the current TDS, fancyvec, windbarb etc.. (these are >>> excellent and we use them already).. what I would like to do is add >>> a scaling notion to them.. so the arrows can indicate direction as >>> well as magnitude, and not just through colour but with their size.. >>> as per a traditional 'quiver' plot.. e.g.: >>> >>> http://matplotlib.org/examples/pylab_examples/quiver_demo.html >>> >>> >>> >>> for this i'm expecting to find where the arrow is created and scale >>> it, and include that modified version of ncwms in our thredds WAR file. >>> >>> >>> >>> apologies if i misunderstood your email or am on the wrong track here.. >>> >>> >>> >>> -i >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> *De :*Kyle Wilcox [mailto:KWilcox@xxxxxxxxxxxxxx] *Envoyé :* >>> Tuesday, >>> 26 March 2013 13:58 *À :* Ivan Price; thredds@xxxxxxxxxxxxxxxx >>> <mailto:thredds@xxxxxxxxxxxxxxxx> *Objet :* RE: ncwms customisation >>> from TDS source.. >>> >>> >>> >>> Hi Ivan - >>> >>> >>> >>> The new vector styles are already available in the newest TDS. >>> >>> >>> >>> I've attached an image showing the vector style options. In >>> addition to the attached, there is also the "barb" style. >>> >>> >>> >>> Here is an example: >>> http://64.9.200.113:8080/thredds/catalog/glos/glcfs/ontario/fcfmrc-3 >>> d >>> / >>> catalog.html?dataset=glos/glcfs/ontario/fcfmrc-3d/Lake_Ontario_-_3D_ >>> b >>> e >>> st.ncd >>> >>> >>> >>> If you take a look at the WMS service, the new vector styles are advertised. >>> >>> >>> >>> Hope this helps, >>> >>> Kyle >>> >>> >>> >>> >>> >>> *From:*thredds-bounces@xxxxxxxxxxxxxxxx >>> <mailto:thredds-bounces@xxxxxxxxxxxxxxxx> >>> [mailto:thredds-bounces@xxxxxxxxxxxxxxxx] *On Behalf Of *Ivan Price >>> *Sent:* Tuesday, March 26, 2013 5:35 AM >>> *To:* thredds@xxxxxxxxxxxxxxxx <mailto:thredds@xxxxxxxxxxxxxxxx> >>> *Subject:* [thredds] ncwms customisation from TDS source.. >>> >>> >>> >>> >>> >>> Hi there, >>> >>> >>> >>> I would like to bite the bullet and have a shot at building a new >>> vector style in the ncwms inside TDS capable of presenting >>> magnitude, for example scaling the currently existing 'stumpvec' >>> style to show wind/current strength etc. >>> >>> >>> >>> i've downloaded the source from github and can build the WAR, and am >>> now in the process of finding where the relevant code to modify is. >>> >>> >>> >>> from what i can see the ncwms component is not built when you build >>> TDS, it seems the file ncwms-1.0.tds.4.3.20130116.1130.jar is >>> downloaded during the build process and used directly. >>> >>> >>> >>> At the risk of asking a very basic question, how do i go about >>> building a new (compiled) ncwms.jar, compatible with the built TDS WAR file >>> ? >>> >>> >>> >>> and secondly, i have searched for where the 'new' vector styles are >>> defined ('fancyvec', 'stumpvec' etc).. but i cannot find them. I >>> have found the original vector style drawing code here: >>> >>> \thredds-master\lib\release\source\ncwms\uk\ac\rdg\resc\ncwms\graphi >>> c >>> s >>> \ImageProducer.java >>> >>> but not the new arrow styles. >>> >>> >>> >>> any help with those two points would be much appreciated, >>> >>> >>> >>> thanks, >>> >>> >>> >>> -ivan >>> >>> >>> >>> >>> >>> >>> >>> _______________________________________________ >>> thredds mailing list >>> thredds@xxxxxxxxxxxxxxxx >>> For list information or to unsubscribe, visit: >>> http://www.unidata.ucar.edu/mailing_lists/ >>> >> > -- Ethan Davis UCAR Unidata Program edavis@xxxxxxxxxxxxxxxx http://www.unidata.ucar.edu _______________________________________________ thredds mailing list thredds@xxxxxxxxxxxxxxxx For list information or to unsubscribe, visit: http://www.unidata.ucar.edu/mailing_lists/
Attachment:
vector-scaling.patch
Description: vector-scaling.patch
thredds archives: